Skip to content

chore: update uuid to ^11.1.1 in sixth chunk of packages - #4358

Merged
grayside merged 4 commits into
mainfrom
fix/uuid-update-chunk-6
Jun 22, 2026
Merged

chore: update uuid to ^11.1.1 in sixth chunk of packages#4358
grayside merged 4 commits into
mainfrom
fix/uuid-update-chunk-6

Conversation

@angelcaamal

@angelcaamal angelcaamal commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Fixes Internal: b/508686791

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: jobs Issues related to the Cloud Talent Solution Job Search API. api: translate Issues related to the Cloud Translation API. api: vision Issues related to the Cloud Vision API. labels Jun 22, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jun 22, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the uuid dependency from ^10.0.0 to ^11.1.1 across multiple packages (storagetransfer, talent, translate, and vision). The reviewer pointed out that uuid v11 drops support for Node.js versions older than 18, which conflicts with the packages' current engine requirements of >=16.0.0. To prevent compatibility issues, the reviewer suggests either upgrading the minimum Node.js version in engines.node to >=18.0.0 or keeping uuid at ^10.0.0.

Comment thread storagetransfer/package.json
Comment thread talent/package.json
Comment thread translate/package.json
Comment thread vision/package.json
@angelcaamal
angelcaamal marked this pull request as ready for review June 22, 2026 19:31
@angelcaamal
angelcaamal requested review from a team as code owners June 22, 2026 19:31
@grayside
grayside merged commit ef2f0ea into main Jun 22, 2026
28 checks passed
@grayside
grayside deleted the fix/uuid-update-chunk-6 branch June 22, 2026 21:52
This was referenced Jun 23, 2026
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grayside grayside grayside approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: jobs Issues related to the Cloud Talent Solution Job Search API. api: translate Issues related to the Cloud Translation API. api: vision Issues related to the Cloud Vision API. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@angelcaamal @grayside